Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements #13

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

zoedberg
Copy link
Collaborator

No description provided.

@dr-orlovsky
Copy link
Member

Can you please explain what happens with the tx mining? Is it the case that a block can be mined but tx doesn't get there?

@zoedberg
Copy link
Collaborator Author

Can you please explain what happens with the tx mining? Is it the case that a block can be mined but tx doesn't get there?

With the current tests this never happens, everytime you mine a block the TX gets mined. But in the future with many more tests we could end up with blocks being full and therefore we could mine a block and not be sure the TX just broadcasted has been inserted in the mined block. So the commit 3f3c00a is not necessary now (and maybe will never be considered how many TXs can fit in a block) but since you were saying the non-deterministic behavior we discovered in #6 was due to the TX not always being mined I thought this change would make this part clearer and avoid developers having doubts like this in the future.

Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some questions

tests/utils/helpers.rs Show resolved Hide resolved
tests/start_services.sh Show resolved Hide resolved
tests/utils/helpers.rs Show resolved Hide resolved
Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3f3c00a

@dr-orlovsky dr-orlovsky merged commit 3a7a2e0 into RGB-WG:master Sep 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants